fix: improve runtime detection for Claude Code, Codex CLI, and Hermes#546
Closed
fix: improve runtime detection for Claude Code, Codex CLI, and Hermes#546
Conversation
- detectBinary now searches ~/.local/bin, /usr/local/bin, ~/Library/pnpm, ~/.npm-global/bin before falling back to PATH lookup - Hermes detection uses --help (exits 0) instead of --version (exits 2) - Hermes version extracted from banner output despite non-zero exit code - Hermes auth checks ~/.hermes/config.yaml for configured model - Codex auth checks OPENAI_API_KEY env var in addition to config files - Version strings cleaned to skip [lacp] wrapper noise - resolvedBin tracked through detection for accurate auth status calls
Member
Author
|
Superseded by #547 which includes these detection fixes plus the onboarding redesign. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes runtime detection so all 4 agent runtimes (OpenClaw, Hermes, Claude Code, Codex CLI) are properly detected when installed.
Root causes:
detectBinaryonly searched PATH — missed~/.local/binand~/Library/pnpmwhere Claude/Codex are typically installed--versionexits with status 2 (not a supported flag) — detection was checking for status 0OPENAI_API_KEYenv var[lacp]wrapper noiseFixes:
detectBinarynow searches~/.local/bin,/usr/local/bin,~/Library/pnpm,~/.npm-global/binbefore PATH--help(exits 0), extracts version from--versionbanner output~/.hermes/config.yamlfor configured modelOPENAI_API_KEYenv varTest plan