Introduce http client profile option for custom configuration #3165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolfeidau
force-pushed
the
feat_http_client_profile
branch
2 times, most recently
from
ec60825 to
a6ea19e
Compare
DrJosh9000
approved these changes
Jan 28, 2025
wolfeidau
force-pushed
the
feat_http_client_profile
branch
from
7f050e8 to
283cc36
Compare
Better description of the valid http client profiles. Co-authored-by: Josh Deprez <[email protected]>
wolfeidau
force-pushed
the
feat_http_client_profile
branch
from
283cc36 to
89aeb92
Compare
|
@DrJosh9000 great point, the agent now reports a conflict for that particular setting.
|
patrobinson
reviewed
Feb 2, 2025
| switch conf.HTTPClientProfile { | ||
| case ClientProfileStdlib: | ||
| // Base any modifications on the default transport. | ||
| transport := http.DefaultTransport.(*http.Transport).Clone() |
There was a problem hiding this comment.
As far as I can tell https://go-review.googlesource.com/c/net/+/617655 is merged but not released. So using the default option would re-introduce the bug we fixed in #3005?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We have customers using the agent in a number of different environments, across different cloud services all over the world, so different configuration profiles for the HTTP client would be valueble.
Context
The Go HTTP client has a log of configurable timeouts, passing all these through is not sustainable so we need a way to bless a subset of configuration and provide this with a generic name, hence the idea of configuration profiles.
On top of this different version of Go introduce new features, and new timeouts, so we also need a way to introduce new profiles as the HTTP Client evolves.
Changes
This change introduces a flag which allows us to add HTTP client configurations which allows us to provide new profiles for customers, while also providing an unconfigured standard library profile to take advantage of the current defaults.
To get the ball rolling I have created a stdlib profile which applies the absolulte minimum configuration, this includes tlsconfig overrides, and the timeout value. Disabling H2 is not provided as this is avaliable via the
GODEBUGenvironment variable supported by the Go Team. https://pkg.go.dev/net/http#hdr-HTTP_2Testing
go test ./...). Buildkite employees may check this if the pipeline has run automatically.go fmt ./...)