Conversation
DrJosh9000
reviewed
Jan 20, 2025
Removes checking command in favour of lt/gt from UID examples
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
We've seen builds where the order of installs from the
install-utilsscript can impact thegidof thedockergroup, but we specify thatdockermust be in993in our GOSS testelastic-ci-stack-for-aws/goss.yaml
Line 104 in 9965c10
The install order in our instance build can determine the GIDs that packages get;
install-utilsruns first, so993may be taken by the time we install Docker.Change
We allow the
dockergroup to have a GID between990and995, inclusive. We could expand this, but it feels like a fine range to start with given we aren't aiming to add lots of packages.