Prefer targets over stacks #790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When creating a new buildpack, use --targets instead of the deprecated --stacks Signed-off-by: Aidan Delaney <[email protected]>
AidanDelaney
force-pushed
the
fix-786/deprecate-stacks
branch
from
70fd180 to
1491ad1
Compare
docs/.github/workflows/main.yml Line 29 in 02f1cbf It's time to update the pack version in the GitHub workflow/actions? |
gogolok
reviewed
Dec 2, 2024
| @@ -25,7 +25,7 @@ pack buildpack new examples/node-js \ | |||
| --api 0.10 \ | |||
| --path node-js-buildpack \ | |||
| --version 0.0.1 \ | |||
| --stacks io.buildpacks.samples.stacks.noble | |||
| --targets "linux/amd64" | |||
There was a problem hiding this comment.
question: While you are here, maybe
diff --git a/content/docs/for-buildpack-authors/tutorials/basic-buildpack/02_building-blocks-cnb.md b/content/docs/for-buildpack-authors/tutorials/basic-buildpack/02_building-blocks-cnb.md
index 55c72761..6ddb7977 100644
--- a/content/docs/for-buildpack-authors/tutorials/basic-buildpack/02_building-blocks-cnb.md
+++ b/content/docs/for-buildpack-authors/tutorials/basic-buildpack/02_building-blocks-cnb.md
@@ -34,7 +34,7 @@ This command will create `node-js-buildpack` directory which contains `buildpack
- `-a, --api` Buildpack API compatibility of the generated buildpack
- `-h, --help` Help for 'new'
- `--path` the location on the filesystem to generate the artifacts
-- `--stacks` Stacks (deprecated) the buildpack will work with
+- `--targets` OS and arch the buildpack will target
- `-V, --version` the version of the buildpack in buildpack.tomlor similar makes sense?
There was a problem hiding this comment.
I've bumped this in #793. We will update the text when your changes to pack --targets lands. buildpacks/pack#2296
|
Thanks a lot for your work on this |
Signed-off-by: Aidan Delaney <[email protected]>
Update from deprecated hugo function Signed-off-by: Aidan Delaney <[email protected]>
AidanDelaney
force-pushed
the
fix-786/deprecate-stacks
branch
from
86f099a to
636d8f2
Compare
jkutner
approved these changes
Jan 31, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Jan 31, 2025
* Prefer targets over stacks When creating a new buildpack, use --targets instead of the deprecated --stacks Signed-off-by: Aidan Delaney <[email protected]> * Migrated to latest hugo toCSS Update from deprecated hugo function Signed-off-by: Aidan Delaney <[email protected]> --------- Signed-off-by: Aidan Delaney <[email protected]> Signed-off-by: Aidan Delaney <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating a new buildpack, use --targets instead of the deprecated --stacks
fixes: #786