Consistently include <math.h> with angle brackets#4794
Open
StephanTLavavej wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bullet3 almost always properly includes the Standard header
math.hwith angle brackets, but there are two lines that inconsistently use double quotes (which could pick up something in the local directory). This PR changes bullet3 to consistently use angle brackets.(We found this for a complicated reason. I'm the primary maintainer of MSVC's STL, and I'm working with @Codiferous who's implementing
constexpr <cmath>in the MSVC compiler. This involves "intercepting" inclusions ofmath.hbut that only works with angle brackets. In any event, consistently using angle brackets is good for all compilers on all platforms, not just because of our weird reason.)