Skip to content

Commit

Permalink
Stop running 2.x build on 1.x branch
Browse files Browse the repository at this point in the history
  • Loading branch information
LachlanMcKee committed Aug 30, 2024
1 parent 9d61c45 commit 2786dfa
Show file tree
Hide file tree
Showing 5 changed files with 19 additions and 6 deletions.
2 changes: 2 additions & 0 deletions .github/workflows/build_1.x.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ on:
branches:
- 1.x
pull_request:
branches:
- 1.x
workflow_dispatch:

env:
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/build_2.x.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ on:
branches:
- 2.x
pull_request:
branches:
- 2.x
workflow_dispatch:

env:
Expand Down
18 changes: 14 additions & 4 deletions build.gradle.kts
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import com.android.Version
import org.jetbrains.kotlin.gradle.dsl.JvmTarget
import org.jetbrains.kotlin.gradle.dsl.KotlinVersion
import org.jetbrains.kotlin.gradle.tasks.KotlinCompile
Expand Down Expand Up @@ -100,10 +101,19 @@ tasks.withType(KotlinJvmCompile::class.java).configureEach {

allprojects {
configurations.all {
resolutionStrategy.dependencySubstitution {
substitute(module("com.bumble.appyx:customisations"))
.using(project(":libraries:customisations"))
.because("RIBs uses Appyx customisations as external dependency")
resolutionStrategy {
failOnNonReproducibleResolution()
dependencySubstitution {
substitute(module("com.bumble.appyx:customisations"))
.using(project(":libraries:customisations"))
.because("RIBs uses Appyx customisations as external dependency")
}
eachDependency {
when (requested.group) {
// Version 1.0 and 1.1 are included which cause ':libraries:core' espresso tests to fail
"androidx.tracing" -> useVersion(libs.versions.androidx.tracing.get())
}
}
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion gradle/libs.versions.toml
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ androidTargetSdk = "34"
accompanist = "0.28.0"
androidx-lifecycle = "2.6.1"
androidx-navigation-compose = "2.5.1"
androidx-tracing = "1.2.0"
coil = "2.2.1"
composeBom = "2024.04.00"
ribs = "0.39.0"
Expand All @@ -27,7 +28,6 @@ androidx-lifecycle-common = { module = "androidx.lifecycle:lifecycle-common", ve
androidx-lifecycle-java8 = { module = "androidx.lifecycle:lifecycle-common-java8", version.ref = "androidx-lifecycle" }
androidx-lifecycle-runtime = { module = "androidx.lifecycle:lifecycle-runtime-ktx", version.ref = "androidx-lifecycle" }
androidx-navigation-compose = { module = "androidx.navigation:navigation-compose", version.ref = "androidx-navigation-compose" }
androidx-tracing = "androidx.tracing:tracing:1.2.0"
androidx-test-espresso-core = "androidx.test.espresso:espresso-core:3.6.0"
androidx-test-junit = "androidx.test.ext:junit:1.2.0"
androidx-test-rules = "androidx.test:rules:1.6.0"
Expand Down
1 change: 0 additions & 1 deletion libraries/core/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,6 @@ dependencies {
api(libs.androidx.appcompat)
api(libs.kotlin.coroutines.android)

debugImplementation(libs.androidx.tracing) // Espresso fails without this
implementation(composeBom)
implementation(libs.androidx.activity.compose)
implementation(libs.androidx.lifecycle.java8)
Expand Down

0 comments on commit 2786dfa

Please sign in to comment.