Position alignment #539
Merged
Position alignment #539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...x-interactions/common/src/commonMain/kotlin/com/bumble/appyx/interactions/sample/Children.kt
Outdated
Show resolved
Hide resolved
...common/src/commonMain/kotlin/com/bumble/appyx/interactions/core/ui/property/impl/Position.kt
Outdated
Show resolved
Hide resolved
manuel-martos
approved these changes
Jul 24, 2023
...actions/common/src/commonMain/kotlin/com/bumble/appyx/interactions/core/DraggableChildren.kt
Outdated
Show resolved
Hide resolved
2 tasks
This was referenced Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allows
Positionto take anAlignmentthat can be animated: #465OffsetandAlignmentcan be used independently or together too – the latter allows to define positions that are relative to an anchor, e.g.Position.Target(Alignment.Center, DpOffset(50.dp, 50.dp))Alignmentcan be anyBiasAlignment, fractional numbers work too (e.g.0.5f=50%betweenCenterandEnd)TestDrive-based examples now animateAlignmentinstead ofDpOffset= they're no longer dependent on the available screen space.This PR should also unlock some better shared element transition capabilities (not in the layout sense, but on the level of visual effects experienced), we should build a small demo for it.
I expect screenshot tests to break as e.g.
CenterStart/CenterEndwill not be exactly where the previous ad-hoc offsets were set.Check list
CHANGELOG.mdif required.