Desktop widget representation #542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zsoltk
reviewed
Jul 25, 2023
Comment on lines
32
to
54
| private val created: TargetUiState = TargetUiState( | ||
| rotationX = RotationX.Target(0f), | ||
| position = Position.Target(DpOffset(0.dp, height)), | ||
| scale = Scale.Target(2.5f), | ||
| alpha = Alpha.Target(0f), | ||
| zIndex = ZIndex.Target(0f), | ||
| ) | ||
|
|
||
| private val standard: TargetUiState = TargetUiState( | ||
| rotationX = RotationX.Target(0f), | ||
| position = Position.Target(DpOffset.Zero), | ||
| scale = Scale.Target(1f), | ||
| alpha = Alpha.Target(1f), | ||
| zIndex = ZIndex.Target(0f), | ||
| ) | ||
|
|
||
| private val destroyed: TargetUiState = TargetUiState( | ||
| rotationX = RotationX.Target(0f), | ||
| position = Position.Target(DpOffset(0.dp, -height)), | ||
| scale = Scale.Target(0.25f), | ||
| alpha = Alpha.Target(0f), | ||
| zIndex = ZIndex.Target(0f), | ||
| ) |
There was a problem hiding this comment.
I suppose these don't affect the rendering since the widget doesn't trigger Spotlight's element state change operations, only scroll change, and then most of the UI is functional in TargetUiState::toMutableUiState? In that case we could just remove this as a red herring.
There was a problem hiding this comment.
You're right. I'll just leave a default one inside private companion object as we still need it for toUiTargets method.
zsoltk
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Create specific representation for Desktop Widget sample.
Fixes #529
Check list
CHANGELOG.mdif required.