[#600] Avoid gesture-related modifier if gestures are disabled #707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...src/commonMain/kotlin/com/bumble/appyx/interactions/composable/AppyxInteractionsContainer.kt
Outdated
Show resolved
Hide resolved
…yx/interactions/composable/AppyxInteractionsContainer.kt Co-authored-by: Andrey Kovalev <[email protected]>
peposdd
force-pushed
the
peposdd/avoid-pointer-event-modifier-if-gestures-disabled
branch
from
6c63a99
to
0bf26af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #600
The
.onPointerEventmodifier applied to the parentBoxof the container was always active, even whenisGesturesEnabledwas set to false. This caused unnecessary interception of gestures, preventing them from properly propagating up the view tree.The fix is conditionally applying the
.onPointerEventmodifier only whenisGesturesEnabledis true. This ensures that gestures are intercepted only when necessary, allowing them to propagate correctly when gestures are disabled.Checklist
CHANGELOG.mdif required.