Explicitly set passive to false when binding mouse wheel event listeners #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mousewheel event listeners registered on document level targets in Chrome will be treated as passive unless explicitly set to false. Calling preventDefault inside passive listeners is ignored and logs a console error. I've changed the mousewheel add listener calls to now explicitly set passive to false when needed.
|
Hi @Bigfellahull, thanks for the pull request! I want to give @bumbu a chance to review this, if he has time, so I'm going to wait before merging. |
This was referenced Oct 29, 2019
|
Looks good as long as we make sure it doesn't break in other browsers |
|
This is working as intended, fixed my problems on Chrome. |
|
Thanks for the pull request and sorry for the delay in responding. My job has shifted away from front end, so I unfortunately can't keep up with maintenance. Would you be interested in becoming a maintainer? |
zkxs
added a commit
to zkxs/zkxs.github.com
that referenced
this pull request
Mar 1, 2022
|
Should be fixed now in a408e0c |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mousewheel event listeners registered on document level targets in Chrome will be treated as passive unless explicitly set to false. Calling preventDefault inside passive listeners is ignored and logs a console error. I've changed the mousewheel add listener calls to now explicitly set passive to false when needed.
This should address issue #337 and #331.