chore: add in xion asset base spec msgs #81
Conversation
Peartes
force-pushed
the
feat/xion-asset
branch
from
be618c1 to
d0c79a7
Compare
Peartes
changed the title
| } | ||
|
|
||
| listing.reserved = Some(Reserve { | ||
| reserver: reservation.reserver.clone(), |
There was a problem hiding this comment.
This is an unsafe call. Addr types are not sanitized from msgs. Even though the type is set, the address might be invalid, and needs to be checked
|
|
||
| #[cw_serde] | ||
| pub struct Reserve { | ||
| pub reserver: Addr, |
There was a problem hiding this comment.
Addr types are good for state storage, but not good for msg types, because of their lack of sanitization. You probably can't reuse the state definition for the msg definition. Also, you likely want to make the reserver optional, and if unset, uses the msg sender
| .iter() | ||
| .find(|coin| coin.denom == price.denom) | ||
| .ok_or_else(|| ContractError::NoPayment {})? | ||
| .clone(); |
There was a problem hiding this comment.
What happens if multiple coins are sent? Seems like everything other than the first match will be stuck in the contract. If only one token is expected, it should be enforced
There was a problem hiding this comment.
Adjusted to fail the tx if multiple coins are sent
| .ok_or_else(|| ContractError::NoPayment {})? | ||
| .clone(); | ||
|
|
||
| if payment.amount.lt(&price.amount) || payment.denom != price.denom { |
There was a problem hiding this comment.
This checks if you underpaid, which is good, but does not check if you overpaid. Do we intend to let people overpay? If so, that will need to be explicitly documented
There was a problem hiding this comment.
we have an exact price plugin that can be set to enforce the exact price of an asset is sent. If this isn't set, only underpayments are considered. Should we fail on overpayments regardless ?
| id: String, | ||
| price: Coin, | ||
| reservation: Option<Reserve>, | ||
| marketplace_fee_bps: Option<u16>, |
There was a problem hiding this comment.
This initialism is never defined anywhere. I don't know what it means
There was a problem hiding this comment.
this is sent in the listing msg and is the marketplace fee in basis point
| }); | ||
| } | ||
|
|
||
| let (validated_marketplace_fee_bps, validated_marketplace_fee_recipient) = |
There was a problem hiding this comment.
Seems like these marketplace values can be set by the lister. How do they interact with the marketplace? Why would someone listing an asset set them?
There was a problem hiding this comment.
an individual listing an item would not set this. This is strictly for scenarios where marketplaces are the ones listing and want to set a fee
|
|
||
| listing.reserved = Some(Reserve { | ||
| reserver: reservation.reserver.clone(), | ||
| reserved_until: reservation.reserved_until, |
There was a problem hiding this comment.
Is there any bound on this value? Or can I just reserve something for 10,000,000 years?
There was a problem hiding this comment.
there is a time lock plugin that sets the maximum duration an asset can be reserved for and is enforced upon reservation but if the time lock plugin is not set, the asset can be reserved indefinitely until unreserved by the owner or approvals
| .add_attribute("price", price.amount.to_string()) | ||
| .add_attribute("denom", price.denom) | ||
| .add_attribute("seller", seller.to_string()) | ||
| .add_attribute("buyer", buyer.to_string()); |
There was a problem hiding this comment.
this doesn't include all of the data necessary for backing out the pricing. marketplace configuration args should be output here as well
There was a problem hiding this comment.
they are included early if the marketplace config was set or not at all
2 participants
This is the Asset standard Contract. Details on the design is here