-
Notifications
You must be signed in to change notification settings - Fork 29
on grant change feature #304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: ce6515d The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
||
### Grant Change Handling | ||
|
||
When using the auto logout feature, consider these best practices: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like the wording "auto logout feature" is ambiguous here. Maybe we should rename this feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what about "grant consistency checkup"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we settled on autoLogoutOnGrantChange
updated the code for the correct behavior
9f447d9
to
f30c3ff
Compare
work done:
grantsChanged
andenableLogoutOnGrantChange
(in their respective places)isLoginInProgress
grantsChanged defaults to truecould be better? yes a bit
how?, more on the real-time detection of the changes in the grants
is it worth the work? maybe, but probably not, as it already detects the flow we desire
Testing steps:
assuming you have everything installed and you are in the xion.js folder
you will need to modify
apps/demo-app/src/app/layout.tsx
edittreasuryConfig
treasury
with a treasury contract address you control.cd apps/demo-app && yarn dev
then open the page, login and navigate to the page where you can elect between legacy, current modes, there is a new mode called grant change demo, select it.
now modify the treasury info on the dev dashboard
https://dev.testnet.burnt.com/
hit the disconnect button
when logging in again it will ask you to validate the new grant info