Skip to content

Show Race condition in UI loading using Abstraxion State #309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Show Race condition in UI loading using Abstraxion State #309

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 0 additions & 14 deletions apps/demo-app/src/app/loading-state/page.tsx
View file
Open in desktop

This file was deleted.

129 changes: 79 additions & 50 deletions apps/demo-app/src/app/ui-less/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
"use client";
import { useState } from "react";
import { useState, useEffect } from "react";
import {
useAbstraxionAccount,
useAbstraxionSigningClient,
Expand All @@ -9,9 +9,35 @@ import "@burnt-labs/ui/dist/index.css";
import Link from "next/link";

export default function UILessPage(): JSX.Element {
const { data: account, login, logout, isConnecting } = useAbstraxionAccount();
// Direct consumption - no intermediate state
const { data: account, login, logout, isConnecting, isConnected } = useAbstraxionAccount();
const { client } = useAbstraxionSigningClient();
const [isLoggingIn, setIsLoggingIn] = useState(false);
const [showUI, setShowUI] = useState(false);

// After isConnecting resolves to false, wait 1s then show UI
useEffect(() => {
if (!isConnecting && !isLoggingIn) {
const timer = setTimeout(() => {
setShowUI(true);
}, 1000);
return () => clearTimeout(timer);
} else {
setShowUI(false);
}
}, [isConnecting, isLoggingIn]);

// Debug logging to understand state transitions - Shows a race condition between isconnecting and isconnected and account address
useEffect(() => {
console.log('AUTH STATE:', {
isConnecting,
isConnected,
account,
hasAccount: !!account?.bech32Address,
accountAddress: account?.bech32Address,
isLoggingIn,
});
}, [isConnecting, isConnected, account, isLoggingIn]);

const handleLogin = async () => {
try {
Expand All @@ -24,21 +50,8 @@ export default function UILessPage(): JSX.Element {
}
};

if (isLoggingIn) {
return (
<main className="m-auto flex min-h-screen max-w-xs flex-col items-center justify-center gap-4 p-4">
<div className="rounded border border-white/20 p-6 text-center">
<p className="font-bold">You are being redirected...</p>
<p className="text-sm">
This is a custom loading UI - you can style this however you want!
</p>
<div className="mt-4">
<div className="inline-block h-8 w-8 animate-spin rounded-full border-4 border-solid border-current border-r-transparent"></div>
</div>
</div>
</main>
);
}
// Show loading until timer completes and we're ready to show UI
const shouldShowLoading = !showUI;

return (
<main className="m-auto flex min-h-screen max-w-lg flex-col items-center justify-center gap-4 p-4">
Expand All @@ -51,42 +64,58 @@ export default function UILessPage(): JSX.Element {
returns to the app.
</p>

<div className="w-full space-y-4">
<Button
fullWidth
onClick={handleLogin}
structure="base"
disabled={isConnecting}
>
{account.bech32Address ? (
<div className="flex items-center justify-center">
Connected: {account.bech32Address.slice(0, 10)}...
{shouldShowLoading ? (
<div className="w-full flex justify-center">
<div className="rounded border border-white/20 p-6 text-center">
<p className="font-bold">
{isConnecting || isLoggingIn ? "Completing authentication..." : "Loading..."}
</p>
<p className="text-sm">
{isConnecting || isLoggingIn ? "Processing your login..." : "Please wait..."}
</p>
<div className="mt-4">
<div className="inline-block h-8 w-8 animate-spin rounded-full border-4 border-solid border-current border-r-transparent"></div>
</div>
) : isConnecting ? (
"LOADING..."
) : (
"CONNECT WALLET"
)}
</Button>
</div>
</div>
) : (
<div className="w-full space-y-4">
<Button
fullWidth
onClick={handleLogin}
structure="base"
disabled={isLoggingIn}
>
{isConnected && account?.bech32Address ? (
<div className="flex items-center justify-center">
Connected: {account.bech32Address.slice(0, 10)}...
</div>
) : (
<div className="flex items-center justify-center">
"CONNECT WALLET"
</div>
)}
</Button>

{account.bech32Address && (
<>
<div className="rounded border border-white/20 p-4">
<h3 className="mb-2 font-semibold">Account Info</h3>
<p className="text-sm text-gray-400">
Address: {account.bech32Address}
</p>
<p className="text-sm text-gray-400">
Client: {client ? "Connected" : "Not connected"}
</p>
</div>
{isConnected && account?.bech32Address && (
<>
<div className="rounded border border-white/20 p-4">
<h3 className="mb-2 font-semibold">Account Info</h3>
<p className="text-sm text-gray-400">
Address: {account?.bech32Address}
</p>
<p className="text-sm text-gray-400">
Client: {client ? "Connected" : "Not connected"}
</p>
</div>

<Button fullWidth onClick={() => logout()} structure="outlined">
DISCONNECT
</Button>
</>
)}
</div>
<Button fullWidth onClick={() => logout()} structure="outlined">
DISCONNECT
</Button>
</>
)}
</div>
)}

<Link
href="/"
Expand Down
Loading
Loading