-
Notifications
You must be signed in to change notification settings - Fork 104
Fix/minfee #376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/minfee #376
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request addresses several important improvements across the codebase, with the primary focus on fixing minimum fee handling and enhancing test coverage. The key changes include implementing missing message methods for MsgSetPlatformMinimum
, strengthening global fee bypass validation, and improving integration test reliability.
- Implements complete SDK message interface for
MsgSetPlatformMinimum
to fix codec/encoding issues - Enforces strict gas limits for bypass messages in global fee ante handler
- Updates coverage reporting thresholds and improves integration test determinism
Reviewed Changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 4 comments.
Show a summary per file
File | Description |
---|---|
x/xion/types/msgs.go |
Implements missing SDK message methods for MsgSetPlatformMinimum |
x/xion/types/msgs_test.go |
Adds comprehensive test coverage for MsgSetPlatformMinimum validation and methods |
x/globalfee/ante/fee.go |
Enforces gas limit validation for bypass messages in fee decorator |
x/globalfee/ante/antetest/fee_test.go |
Adds extensive test cases for bypass gas limit enforcement |
scripts/test-coverage.sh |
Updates coverage thresholds and reporting logic |
integration_tests/minimum_fee_test.go |
Adds codec bug regression test for MsgSetPlatformMinimum |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]> Signed-off-by: TwiceBurnt <[email protected]>
Co-authored-by: Copilot <[email protected]> Signed-off-by: TwiceBurnt <[email protected]>
This reverts commit d9cd39a.
This pull request introduces several improvements and fixes across integration tests, coverage reporting scripts, dependency management, and core logic. The most significant changes include enhanced integration test coverage for message encoding bugs, stricter global fee bypass gas limit enforcement, and updates to coverage reporting thresholds. Additionally, there are dependency cleanups and additions for better test reliability.
Integration test improvements:
TestMsgSetPlatformMinimumCodecBug
tointegration_tests/minimum_fee_test.go
to verify thatMsgSetPlatformMinimum
correctly implements all required methods and encodes/decodes as expected, addressing a prior security report. (Fcdfb898L742R742)TestWebAuthNAbstractAccount
inintegration_tests/webauthn_test.go
by ensuring block commitment before transactions and using deterministic assertions for balance checks. [1] [2]Global fee logic and tests:
TestGlobalFeeSetAnteHandler
inx/globalfee/ante/antetest/fee_test.go
to enforce and validate the maximum bypass gas limit, ensuring excessive gas usage fails as expected and boundary cases pass.Coverage reporting enhancements:
scripts/test-coverage.sh
to raise the threshold for "OK" coverage to 80%, merge low and zero coverage reporting (now <=80%), and clarify output messages for coverage validation. [1] [2] [3] [4]Dependency management:
go.mod
and added/testing new ones inintegration_tests/go.mod
for improved reliability and compatibility. [1] [2] [3] [4] [5] [6]Minor codebase cleanups: