Skip to content

Conversation

2xburnt
Copy link
Contributor

@2xburnt 2xburnt commented Aug 26, 2025

This pull request introduces several improvements and fixes across integration tests, coverage reporting scripts, dependency management, and core logic. The most significant changes include enhanced integration test coverage for message encoding bugs, stricter global fee bypass gas limit enforcement, and updates to coverage reporting thresholds. Additionally, there are dependency cleanups and additions for better test reliability.

Integration test improvements:

  • Added TestMsgSetPlatformMinimumCodecBug to integration_tests/minimum_fee_test.go to verify that MsgSetPlatformMinimum correctly implements all required methods and encodes/decodes as expected, addressing a prior security report. (Fcdfb898L742R742)
  • Improved TestWebAuthNAbstractAccount in integration_tests/webauthn_test.go by ensuring block commitment before transactions and using deterministic assertions for balance checks. [1] [2]

Global fee logic and tests:

  • Added new test cases to TestGlobalFeeSetAnteHandler in x/globalfee/ante/antetest/fee_test.go to enforce and validate the maximum bypass gas limit, ensuring excessive gas usage fails as expected and boundary cases pass.

Coverage reporting enhancements:

  • Updated scripts/test-coverage.sh to raise the threshold for "OK" coverage to 80%, merge low and zero coverage reporting (now <=80%), and clarify output messages for coverage validation. [1] [2] [3] [4]

Dependency management:

  • Removed unused indirect dependencies from go.mod and added/testing new ones in integration_tests/go.mod for improved reliability and compatibility. [1] [2] [3] [4] [5] [6]

Minor codebase cleanups:

  • Removed obsolete comments and improved import statements for clarity and correctness in various files. [1] [2] [3] [4]

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request addresses several important improvements across the codebase, with the primary focus on fixing minimum fee handling and enhancing test coverage. The key changes include implementing missing message methods for MsgSetPlatformMinimum, strengthening global fee bypass validation, and improving integration test reliability.

  • Implements complete SDK message interface for MsgSetPlatformMinimum to fix codec/encoding issues
  • Enforces strict gas limits for bypass messages in global fee ante handler
  • Updates coverage reporting thresholds and improves integration test determinism

Reviewed Changes

Copilot reviewed 17 out of 17 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
x/xion/types/msgs.go Implements missing SDK message methods for MsgSetPlatformMinimum
x/xion/types/msgs_test.go Adds comprehensive test coverage for MsgSetPlatformMinimum validation and methods
x/globalfee/ante/fee.go Enforces gas limit validation for bypass messages in fee decorator
x/globalfee/ante/antetest/fee_test.go Adds extensive test cases for bypass gas limit enforcement
scripts/test-coverage.sh Updates coverage thresholds and reporting logic
integration_tests/minimum_fee_test.go Adds codec bug regression test for MsgSetPlatformMinimum

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@ash-burnt ash-burnt merged commit 031fd24 into release/v22 Sep 2, 2025
31 checks passed
@ash-burnt ash-burnt deleted the fix/minfee branch September 2, 2025 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants