refactor speak.js to allow pre-loaded voices.
#7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
January 2, 2023 16:34
…e global variables.
… to `assets/voices`.
I have identified that the problem reported in the issue #6 is due to the fact that the dialogue text font size uses the `vw` unit. This make it look small in small screen and look large in large screen size as well. Marked for further refactor.
Some of the audio files have not been included because they overlap itself when playing, causing a loud noise: , and .
I added a function to avoid the audio to overlap each other.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Previously, the code was giving the warning 'The AudioContext was not allowed to start'. This commit fixes this issue and adds the @async flag to all the async functions.
Thanks for doing this! I didn't focus on writing clean code much; I made this project in ~5 hours as a part of a hackathon where the main theme was to create projects that have no value whatsoever. (I'll need to add this in the
Yes, I should have let you know about them earlier - the audio files aren't clipped yet. |
burntcarrot
reviewed
Jan 3, 2023
|
I have changed |
burntcarrot
approved these changes
Jan 3, 2023
This was
linked to
issues
Jan 3, 2023
This was referenced Jan 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, @burntcarrot. I have refactored the
speak.jsfile, now renamed toscript.js. The changes I have done:1.5remand controlling overflow with theoverflowrule.selectorwith some of the options of pre-loaded audio I have found atassets/voice, now renamed toassets/voices. Three of the voices:moo.mp3,santa.wavandwoof.mp3were long, causing the audio to overlap each other, making too much noise. For this reason, I have not used them.I hope these changes help you.