Patch recursive project directories #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The workspace and vectors calls currently recursively create project directories within a given project directory. This was happening because the vectors were being instantiated with a project configured with a directory set to
File.basename(Dir.getwd), which was creating a new <my_project> directory within the top level <my_project> directory.This is best solved by just deleting the project argument altogether. We're only using it to locate a directory. Simpler to just assume we're in the project directory when we invoke the command. We could also add some
project.yamlexists? type validation to guarantee you're running in a manifolds project.Also patched a couple of miscellaneous runtime errors surfaced when actually invoking the gem against a real project.