Merge pull request #57 from butschster/hotfix/53

Fixes problem with generating link hreflang tag
butschster · Sep 10, 2023 · 7decc9e · 7decc9e
2 parents 92ffaa1 + eb03bd3
commit 7decc9e
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 2 deletions.
diff --git a/src/MetaTags/Concerns/ManageLinksTags.php b/src/MetaTags/Concerns/ManageLinksTags.php
@@ -98,7 +98,7 @@ public function setHrefLang(string $lang, string $url)
         return $this->addLink('alternate_' . $lang, [
             'rel' => 'alternate',
             'hreflang' => $this->cleanString($lang),
-            'href' => $this->cleanString($url),
+            'href' => $url,
         ]);
     }
 
@@ -129,4 +129,4 @@ public function addLink(string $name, array $attributes)
 
         return $this->addTag($name, Tag::link($attributes));
     }
-}
+}
diff --git a/tests/MetaTags/HrefLangMetaTagsTest.php b/tests/MetaTags/HrefLangMetaTagsTest.php
@@ -38,6 +38,17 @@ function test_hreflang_should_be_null_if_not_set()
         $this->assertNull($this->makeMetaTags()->getHrefLang('en'));
     }
 
+    function test_query_string()
+    {
+        $meta = $this->makeMetaTags()
+            ->setHrefLang('zh-hans', 'https://example.com/?foo=bar&lang=zh-hans');
+
+        $this->assertHtmlableEquals(
+            '<link rel="alternate" hreflang="zh-hans" href="https://example.com/?foo=bar&lang=zh-hans">',
+            $meta->getHrefLang('zh-hans')
+        );
+    }
+
     function test_convert_to_array()
     {
         $meta = $this->makeMetaTags()