fix: Correct the state addressing for Scalar and Rotate #669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@blackspherefollower Welp I fucked up the conflict resolution on this after bringing in your device PR first. Can you rebase? |
|
I'll get on that tomorrow morning |
blackspherefollower
force-pushed
the
mixedfeatures
branch
from
6e05468 to
9ef17d9
Compare
|
@qdot Done |
|
Converted to draft: the tests ran for 5 hours on each platform when I realised CI hadn't actually run tests |
This does not apply to RotateCmd because there isn't a v3->v4 feature index converter yet. Fixes buttplugio#668
blackspherefollower
force-pushed
the
mixedfeatures
branch
from
9ef17d9 to
e67c905
Compare
|
And fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #668