fix: mark cancellation as failure if action reaches completion

bytebeamio · Jun 13, 2024 · 16a75d1 · 16a75d1
1 parent af57577
commit 16a75d1
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/uplink/src/base/bridge/actions_lane.rs b/uplink/src/base/bridge/actions_lane.rs
@@ -414,8 +414,13 @@ impl ActionsBridge {
             if let Some(CurrentAction { cancelled_by: Some(cancel_action), .. }) =
                 self.current_action.take()
             {
-                let response = ActionResponse::success(&cancel_action);
-                self.streams.forward(response).await;
+                if response.is_failed() {
+                    let response = ActionResponse::success(&cancel_action);
+                    self.streams.forward(response).await;
+                } else {
+                    // Marks the cancellation as a failure as action has reached completion without being cancelled
+                    self.forward_action_error(&cancel_action, Error::FailedCancellation).await
+                }
             }
             return;
         }