Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: serializer module code improvements #214

Merged
merged 5 commits into from
Apr 27, 2023
Merged

feat: serializer module code improvements #214

merged 5 commits into from
Apr 27, 2023

Conversation

de-sh
Copy link
Member

@de-sh de-sh commented Apr 26, 2023 •
edited
Loading

Closes #

Changes

  • Make functions private and remove if unused
  • Reorganize Serializer code documentation
  • Explain SerializerMetrics in detail
  • Remove use of MqttClient::publish_bytes as it is equivalent to MqttClient::publish
  • Explain MqttClient

Why?

Trials Performed

Screenshot from 2023-04-27 00-42-30

Screenshot from 2023-04-27 10-28-07

@de-sh de-sh changed the title feat: improve serializer.rs feat: improve serializer module Apr 26, 2023
@de-sh de-sh changed the title feat: improve serializer module feat: serializer module code improvements Apr 26, 2023
@de-sh de-sh merged commit 595a6f5 into main Apr 27, 2023
@de-sh de-sh deleted the improve-serializer.rs branch April 27, 2023 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@de-sh