Repository navigation
fix(bindgen): post return trap completion - #2305
Merged
vados-cosmonic merged 7 commits intoOct 23, 2026
Merged
vados-cosmonic merged 7 commits into
vados-cosmonic merged 7 commits into
Conversation
Catch failures during canonical post-return cleanup and mark the component trapped. Record the task failure even when a result is already recorded, preventing successful async completion after cleanup traps and rejecting subsequent component entry. Co-authored-by: Markus Gritsch <gurkerl83@googlemail.com>
Add shared Rust fixtures and regression tests for synchronous exports, JSPI-wrapped synchronous exports and WIT async exports. Verify that cleanup failures reach the caller and subsequent component entry is rejected. Co-authored-by: Markus Gritsch <gurkerl83@googlemail.com>
Normalize stack exhaustion and core exceptions during post-return, retaining their causes. Guard fused cleanup imports against the owning component and reject task-managed cleanup failures before publishing results.
Keep the result discriminant until the completion handler decides whether to return its payload or reject. This prevents successful post-return cleanup from publishing an err payload as a fulfilled Promise.
Add documented WAT fixtures for direct and composed cleanup traps, async-lowered calls, and result completion with wrapped or raw errors. Check that healthy sibling instances remain callable. Shorten the existing Rust fixture and regression comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #2300