Repository navigation
fix(jco): support QuickJS 0.5 in the TLS fixture - #2310
Merged
vados-cosmonic merged 1 commit intoOct 24, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
QuickJS 0.5.0 gets past the TLS resource linker failure expected by the HTTPS fixture, exposing a missing
TextEncoderduring module evaluation. This causes the CI failure in #2307.Inject Jco's globals when bundling the fixture and let its virtual modules resolve through the builtin plugin. Keep the expected linker failure for QuickJS versions before 0.5.0; require successful componentization and verify the TLS, socket, and shared IO imports for newer versions.
This fix is based on main and retains its QuickJS 0.4.5 dependency, so it can land before #2307 is rebased.
Validation on Linux with Node.js 24.21.0:
The local test setup temporarily aligned ComponentizeJS with Jco's installed preview2-shim instance; dependency links were restored afterward.