translate errno=-4094 errors to "no-such-device" on Windows #454
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an application attempts to open a non-existent path such as `//foo/bar/baz`
on Windows, Node generates an error of the form:
```
{
errno: -4094,
syscall: 'open',
code: 'UNKNOWN',
path: '//foo/bar/baz'
}
```
Prior to this commit, that error would be re-thrown, causing Wasm execution to
trap. Now we convert it to a "no-such-device" error instead.
Signed-off-by: Joel Dice <[email protected]>
dicej
force-pushed
the
windows-no-such-device
branch
from
0fdd543 to
5d3336e
Compare
Contributor
Author
|
Thanks for merging this, @guybedford. Is there a chance we could publish a new release of the shim with this fix soonish? That would help unblock dotnet/runtimelab#2614, which is where I encountered this issue. |
Collaborator
|
Sure, I've pushed a 0.16.3. |
|
This fix was a bit confusing to me, and it took me a while to find the real reason. On Windows, the path emitted by std::fs::read will be prefixed with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an application attempts to open a non-existent path such as
//foo/bar/bazon Windows, Node generates an error of the form:Prior to this commit, that error would be re-thrown, causing Wasm execution to trap. Now we convert it to a "no-such-device" error instead.