Don't enable the "fs" module implicitly. #1175
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Several configurations used to enable the "fs" module as rustix used to use the "procfs" module for reading the AUXV vector on Linux. Rustix no longer does this, as the "procfs" module's extra checks are incompatible with QEMU on one hand, and not needed by most use cases on the other. So since those configurations no longer use the "fs" module, we can remove the code that enabled it.
|
Ah, never mind. This isn't as simple as I thought. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several configurations used to enable the "fs" module as rustix used to use the "procfs" module for reading the AUXV vector on Linux. Rustix no longer does this, as the "procfs" module's extra checks are incompatible with QEMU on one hand, and not needed by most use cases on the other.
So since those configurations no longer use the "fs" module, we can remove the code that enabled it.