Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove preserves_flags on 32-bit x86. #726

Merged
merged 10 commits into from
Jul 5, 2023
Merged

Remove preserves_flags on 32-bit x86. #726

merged 10 commits into from
Jul 5, 2023

Conversation

sunfishcode
Copy link
Member

The __kernel_vsyscall function used on 32-bit x86 does not preserve the flags register, so remove the preserves_flags option on inline asm blocks that call it.

The `__kernel_vsyscall` function used on 32-bit x86 does not preserve
the flags register, so remove the `preserves_flags` option on inline
asm blocks that call it.
This works around missing mipsel-unknown-linux-gnu.
These libraries were built on an older version of Ubuntu than is
still available on Github Actions. This is on the 0.35 branch, so
I don't expect any further updates to these libraries, so just
disable the checks.
Curl is already installed, so just use that, instead of manually
installing curl, which encounters problems.
@sunfishcode sunfishcode force-pushed the 0.35-updates branch 2 times, most recently from 89f93ec to a0d1cca Compare July 5, 2023 14:44
The benchmark depends on criterion, which is complex to support on Rust
1.48 these days.
@sunfishcode sunfishcode merged commit afd5d7f into 0.35 Jul 5, 2023
8 of 10 checks passed
@sunfishcode sunfishcode deleted the 0.35-updates branch July 5, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant