-
Notifications
You must be signed in to change notification settings - Fork 724
Add imported functions callback samples #4606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
bd8d4ae
to
a3578eb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still think we should add some description in the comments of wasm_runtime_get_import_xxx()
in wasm_export.h, perhaps introducing this sample.
Need to execute samples in CI.
ab0d448
to
500e809
Compare
the ci failure doesn't seem like a fault of this PR. |
500e809
to
236ea1f
Compare
can you rebase after #4620? |
236ea1f
to
f4f6c4a
Compare
resolved. I see some tests failed STDERR:
thread 'main' panicked at 'expected errno NOENT; got NOTDIR', src/bin/path_symlink_trailing_slashes.rs:7:9
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace that maybe a github action CI Windows env error. |
|
Please rebase after #4633 |
Signed-off-by: zhenweijin <[email protected]>
f4f6c4a
to
9e5ca08
Compare
resolved. |
In scenarios that require permission control, users may want to know if a Wasm app has the authority to use the native APIs it's about to import. To address this, we've added a callback that executes when the Wasm module loads an imported function.