Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wast: Add exnref, try_table, and throw_ref #1225

Merged
merged 3 commits into from
Oct 2, 2023

Conversation

eqrion
Copy link
Collaborator

@eqrion eqrion commented Sep 28, 2023

These types and instructions are part of the exception handling rework tracked in (WebAssembly/exception-handling#281).

Copy link
Member

@alexcrichton alexcrichton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I think this needs a rustfmt but should otherwise be good to go.

These types and instructions are part of the exception handling rework tracked
in (WebAssembly/exception-handling#281).
@eqrion
Copy link
Collaborator Author

eqrion commented Sep 28, 2023

Just did the rustfmt, but hold up on merging there's been some recent bikeshedding of the binary to work through. I will probably update again.

@eqrion
Copy link
Collaborator Author

eqrion commented Oct 2, 2023

@alexcrichton Okay, this should be good to go now.

@alexcrichton alexcrichton merged commit c950866 into bytecodealliance:main Oct 2, 2023
15 checks passed
@alexcrichton
Copy link
Member

Would you like a crates.io release for this?

@eqrion
Copy link
Collaborator Author

eqrion commented Oct 3, 2023

Would you like a crates.io release for this?

Yes, that would be great.

@alexcrichton
Copy link
Member

Sure thing, doing that in #1227

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants