Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wasmprinter folding: change some panics to errors or successful roundtrips #1840

Merged
merged 2 commits into from
Oct 2, 2024
Merged

wasmprinter folding: change some panics to errors or successful roundtrips #1840

merged 2 commits into from
Oct 2, 2024
+37 −4

Conversation

keithw
Copy link
Contributor

@keithw keithw commented Oct 2, 2024

Fixes #1838

@keithw keithw mentioned this pull request Oct 2, 2024
Closed
@alexcrichton
Copy link
Member

Thanks for this! Mind adding a test as well? Something under tests/cli/*.wat should be fine, probably with a FAIL: print % annotation.

@alexcrichton alexcrichton self-assigned this Oct 2, 2024
@keithw keithw changed the title wasmprinter folding: convert some panics to errors wasmprinter folding: change some panics to errors or successful roundtrips Oct 2, 2024
@keithw
Copy link
Contributor Author

keithw commented Oct 2, 2024

Given that this module is valid, I went back to make it roundtrip and not just error, and added a roundtrip test for that... hope that works.

alexcrichton
alexcrichton approved these changes Oct 2, 2024
View reviewed changes
Copy link
Member

@alexcrichton alexcrichton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! Thanks!

@alexcrichton alexcrichton added this pull request to the merge queue Oct 2, 2024
Merged via the queue into bytecodealliance:main with commit d7f2827 Oct 2, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcrichton alexcrichton alexcrichton approved these changes

Assignees

@alexcrichton alexcrichton

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Panic printing if with folded instructions where parameter is from block param
2 participants
@keithw @alexcrichton