Repository navigation
feat(d): Make use of pragma(inline, true) - #1711
Merged
alexcrichton merged 3 commits intoSep 15, 2026
Merged
Conversation
Contributor
Author
alexcrichton
approved these changes
Sep 15, 2026
alexcrichton
enabled auto-merge
September 15, 2026 21:42
github-merge-queue
Bot
removed this pull request from the merge queue due to a conflict with the base branch
Sep 15, 2026
Contributor
Author
|
Needs to be requeued. There was a merge conflict. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces use of force-inlining across the bindings where valuable to help reduce binary sizes.
When the output of
wit-bindgenis compiled as a separate library from the uses (e.g. when usingdubwith"targetType": "staticLibrary", there ends up being a lot of bloat from tiny wrappers/helpers that LDC avoids inlining, even at-O3. To help fight this,pragma(inline, true)has been added all around where it has helped reduce code size.In my testing, it takes a minimal component implementing https://github.com/Pumpkin-MC/pumpkin-plugin-wit from nearly 1 MB, down to ~ 575 KiB when compiling with
-Oz. This is with thewit-bindgenoutput being emitted in one static library, andexportsin the main compilation. For reference, compiling it all at once without this PR yields a size of 625 KiB. So it helps in both cases.