forked from bytecodeio/looker-explore-assistant
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(perf) Filter construction improvements - Make It Smarter (#131) #1
Open
dbarrbc
wants to merge
2
commits into
make-it-smarter-bytecode
Choose a base branch
from
main
base: make-it-smarter-bytecode
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n-source#131) * Feat make smarter (looker-open-source#91) * fix - pass in the parameters to the big query generate model * make it smater * merge * prevent duplicate triggering of generation * move logic into helper utils * fix state * fix the callbacks * use params instead of a string * add back sorting * fix link generation * remove some consoles * check the filters twice, make sure that we're returning a simpler data structure * fix race condition for page load * separate call for filter and visualization generation * fix typescript errors * add jest tests * update for edge cases when custom urls, and custom dates are in examples need to be handled. * Fix package json * more fixes post merge * fix the store * fix sidepanel * fix the link to explore * improve speed by parallelizing calls to gemini * fix summarization * scroll into view * add filter helper and tests * add tests * run on every commit * only use node 16 and 18 * use a filter validator * remove un-used console logs * post-merge fixes * fix tests * improve scrolling --------- Co-authored-by: Jawad Laraqui <[email protected]> Co-authored-by: Flavio Di Berardino <[email protected]> * Update useSendVertexMessage.ts * Fixed issue with parsing cleaned url Added case statement to handle both cleaned an uncleaned urls * Origin/feature generate examples (#1) * Added generate examples script and trusted dashboard table * Error handling * terraform bug fix * Handle url queryPrompt parameter * generate_exmples bug fix * Added number filter documentation * work in progress - append examples * working and tested new concat function. * tested * Update looker_filter_doc.md adding more context to filter doc on dates * Add files via upload Adding context file on timeframes and intervals * Update useSendVertexMessage.ts adding import and reference for context * Update ExploreFilterHelper.ts updating file * mostly working with new configs * working settings! * refactoring to use lookml queries * working with cloud function and new lookml model * Update useSendVertexMessage.ts reverted/removed inline date and number filter documentation in useSendVertexMessage * made settings admin-only and hide them for regular users. * committing timeframe filter logic * secure fetchProxy added * working with Bigquery! * Fixed problem with variability * remove indeterminacy, fix filter bug * more context with restored filters call * bug fix * bug fix * add back in filter mods * handle NOT NULL better * merge fixes * Update looker_filter_doc.md to help last x timeframe filters Adding more context to distinguish between last x days and x days ago type of filters. * rm trusted dashboards * work in progress on be installer * testing cloud shell script * testing cloud console run * testing * readme updated * test * testing * test * test * test * test * test * test * test * test * readme edits * updated readme * readme update * readme * adding changes * Fixed READMEs * restore 'query object format' text. * testing * testing * security setup * updates for security testing * error handling fixes and example script updates * readme updates * Revert "Merge branch 'marketplace_deploy' into make-it-smarter-bytecode" This reverts commit 954b73b, reversing changes made to cd7ee7e. * Remove 'check the response'. --------- Co-authored-by: Luka Fontanilla <[email protected]> Co-authored-by: Jawad Laraqui <[email protected]> Co-authored-by: Flavio Di Berardino <[email protected]> Co-authored-by: dbarrbc <[email protected]> Co-authored-by: Colin Roy-Ehri <[email protected]> Co-authored-by: colin-roy-ehri <[email protected]> Co-authored-by: carolbethperkins <[email protected]>
dbarrbc
pushed a commit
that referenced
this pull request
Mar 4, 2025
* Added generate examples script and trusted dashboard table
dbarrbc
pushed a commit
that referenced
this pull request
Mar 4, 2025
…tecode Make it smarter more context bytecode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feat make smarter (Feat make smarter looker-open-source/looker-explore-assistant#91)
fix - pass in the parameters to the big query generate model
make it smater
merge
prevent duplicate triggering of generation
move logic into helper utils
fix state
fix the callbacks
use params instead of a string
add back sorting
fix link generation
remove some consoles
check the filters twice, make sure that we're returning a simpler data structure
fix race condition for page load
separate call for filter and visualization generation
fix typescript errors
add jest tests
update for edge cases when custom urls, and custom dates are in examples need to be handled.
Fix package json
more fixes post merge
fix the store
fix sidepanel
fix the link to explore
improve speed by parallelizing calls to gemini
fix summarization
scroll into view
add filter helper and tests
add tests
run on every commit
only use node 16 and 18
use a filter validator
remove un-used console logs
post-merge fixes
fix tests
improve scrolling
Update useSendVertexMessage.ts
Fixed issue with parsing cleaned url
Added case statement to handle both cleaned an uncleaned urls
Origin/feature generate examples ((perf) Filter construction improvements - Make It Smarter (#131) #1)
Added generate examples script and trusted dashboard table
Error handling
terraform bug fix
Handle url queryPrompt parameter
generate_exmples bug fix
Added number filter documentation
work in progress - append examples
working and tested new concat function.
tested
Update looker_filter_doc.md
adding more context to filter doc on dates
Adding context file on timeframes and intervals
adding import and reference for context
updating file
mostly working with new configs
working settings!
refactoring to use lookml queries
working with cloud function and new lookml model
Update useSendVertexMessage.ts
reverted/removed inline date and number filter documentation in useSendVertexMessage
made settings admin-only and hide them for regular users.
committing timeframe filter logic
secure fetchProxy added
working with Bigquery!
Fixed problem with variability
remove indeterminacy, fix filter bug
more context with restored filters call
bug fix
bug fix
add back in filter mods
handle NOT NULL better
merge fixes
Update looker_filter_doc.md to help last x timeframe filters
Adding more context to distinguish between last x days and x days ago type of filters.
rm trusted dashboards
work in progress on be installer
testing cloud shell script
testing cloud console run
testing
readme updated
test
testing
test
test
test
test
test
test
test
test
readme edits
updated readme
readme update
readme
adding changes
Fixed READMEs
restore 'query object format' text.
testing
testing
security setup
updates for security testing
error handling fixes and example script updates
readme updates
Revert "Merge branch 'marketplace_deploy' into make-it-smarter-bytecode"
This reverts commit 954b73b, reversing changes made to cd7ee7e.