[fix][cp] fix: Untangle some strange code in PlanBuilder::finalAggregation() …#446
Open
WangGuangxin wants to merge 1 commit intobytedance:mainfrom
Open
[fix][cp] fix: Untangle some strange code in PlanBuilder::finalAggregation() …#446WangGuangxin wants to merge 1 commit intobytedance:mainfrom
PlanBuilder::finalAggregation() …#446WangGuangxin wants to merge 1 commit intobytedance:mainfrom
Conversation
…(#12466) Summary: The problematic code was brought in facebookincubator/velox#1419. The code block is actually ```cpp if (!a) { VELOX_CHECK(a); } ``` which is apparently wrong. The code was intentionally to find an aggregation with `Step::kPartial`. The patch recovers the right readable logic. Pull Request resolved: facebookincubator/velox#12466 Reviewed By: kagamiori Differential Revision: D71768609 Pulled By: xiaoxmeng fbshipit-source-id: 4da81c6f7ddba2fc550da30ee95c286d9618c81c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #191
Type of Change
Description
The code block is actually
which is apparently wrong. The code was intentionally to find an aggregation with
Step::kPartial. The patch recovers the rightreadable logic.
Performance Impact
No Impact: This change does not affect the critical path (e.g., build system, doc, error handling).
Positive Impact: I have run benchmarks.
Click to view Benchmark Results
Negative Impact: Explained below (e.g., trade-off for correctness).
Release Note
Checklist (For Author)
Breaking Changes
No
Yes (Description: ...)
Click to view Breaking Changes