[fix][cp] fix: Make BaseVector::flattenVector unwrap lazy vectors#449
Open
WangGuangxin wants to merge 1 commit into
Open
[fix][cp] fix: Make BaseVector::flattenVector unwrap lazy vectors#449WangGuangxin wants to merge 1 commit into
BaseVector::flattenVector unwrap lazy vectors#449WangGuangxin wants to merge 1 commit into
Conversation
Summary: Fixes facebookincubator/velox#14492, facebookincubator/velox#14021. Currently `BaseVector::flattenVector` doesn't unwrap lazy vectors. This patch makes it unwrap the lazy vectors. It should also fix a bunch of vulnerabilities in the code base. For example code like: https://github.com/facebookincubator/velox/blob/42193a8015081187e06ed4e8ed77b2bb1002a236/velox/expression/FieldReference.cpp#L176-L179 could crash the program with a lazy input. Some historical issues that relate to this topic: facebookincubator/velox#6168 facebookincubator/velox#6170 facebookincubator/velox#8697 facebookincubator/velox#9282 Pull Request resolved: facebookincubator/velox#14491 Reviewed By: kKPulla Differential Revision: D84733842 Pulled By: pedroerp fbshipit-source-id: a48cd6d9e2ba3ed96a0829b21b9c4c9a92767377
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #191
Type of Change
Description
Currently
BaseVector::flattenVectordoesn't unwrap lazy vectors. This patch makes it unwrap the lazy vectors.Performance Impact
No Impact: This change does not affect the critical path (e.g., build system, doc, error handling).
Positive Impact: I have run benchmarks.
Click to view Benchmark Results
Negative Impact: Explained below (e.g., trade-off for correctness).
Release Note
Checklist (For Author)
Breaking Changes
No
Yes (Description: ...)
Click to view Breaking Changes