Skip to content

[fix][cp] Use mutex lock to protect cache shutdown#537

Open
Weixin-Xu wants to merge 1 commit intobytedance:mainfrom
Weixin-Xu:async_datacache
Open

[fix][cp] Use mutex lock to protect cache shutdown#537
Weixin-Xu wants to merge 1 commit intobytedance:mainfrom
Weixin-Xu:async_datacache

Conversation

@Weixin-Xu
Copy link
Copy Markdown
Collaborator

@Weixin-Xu Weixin-Xu commented May 6, 2026

Summary:
Currently, SSD cache use atomics to handle shutdown and writeInProgress counter which are used a lock to prevent concurrent writes to a SSD file. It is better to use mutex to ease the implementation and also prevent any write to SSD file if shutdown has been triggered.

What problem does this PR solve?

Issue Number: close #xxx

Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 🚀 Performance improvement (optimization)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)
  • 🔨 Refactoring (no logic changes)
  • 🔧 Build/CI or Infrastructure changes
  • 📝 Documentation only

Description

Describe your changes in detail.
For complex logic, explain the "Why" and "How".

Performance Impact

  • No Impact: This change does not affect the critical path (e.g., build system, doc, error handling).

  • Positive Impact: I have run benchmarks.

    Click to view Benchmark Results
    Paste your google-benchmark or TPC-H results here.
    Before: 10.5s
    After:   8.2s  (+20%)
    
  • Negative Impact: Explained below (e.g., trade-off for correctness).

Release Note

Please describe the changes in this PR

Release Note:

Release Note:
- Fixed a crash in `substr` when input is null.
- optimized `group by` performance by 20%.

Checklist (For Author)

  • I have added/updated unit tests (ctest).
  • I have verified the code with local build (Release/Debug).
  • I have run clang-format / linters.
  • (Optional) I have run Sanitizers (ASAN/TSAN) locally for complex C++ changes.
  • No need to test or manual test.

Breaking Changes

  • No

  • Yes (Description: ...)

    Click to view Breaking Changes
    Breaking Changes:
    - Description of the breaking change.
    - Possible solutions or workarounds.
    - Any other relevant information.
    

Summary:
Currently, SSD cache use atomics to handle shutdown and writeInProgress counter which are used a lock to prevent concurrent writes to a SSD file. It is better to use mutex to ease the implementation and also prevent any write to SSD file if shutdown has been triggered.

Co-authored-by: Zac Wen <zacw@meta.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant