[Expr][Gluten] Fix decimal ceil remainder overflow#543
Open
wangxinshuo-bolt wants to merge 1 commit intobytedance:mainfrom
Open
[Expr][Gluten] Fix decimal ceil remainder overflow#543wangxinshuo-bolt wants to merge 1 commit intobytedance:mainfrom
wangxinshuo-bolt wants to merge 1 commit intobytedance:mainfrom
Conversation
Ported from b984a87e3c0686d1805cf1d583e35db5104ebc13 on fix_ceil_decimal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #544
Type of Change
Description
Store the remainder using the divisor type B, which is wide enough for the decimal scale involved in the operation:
This keeps the rounding decision based on the full decimal-scale remainder while preserving the original result type for the final quotient.
Added regression coverage for the long-decimal ceil case and moved/refactored related decimal vector function tests so the Spark decimal test target includes the relevant coverage.
Performance Impact
No Impact: This change does not affect the critical path (e.g., build system, doc, error handling).
Positive Impact: I have run benchmarks.
Click to view Benchmark Results
Negative Impact: Explained below (e.g., trade-off for correctness).
Checklist (For Author)
Breaking Changes
No
Yes (Description: ...)
Click to view Breaking Changes