fix: avoid buffer resize cost in shuffle reader during InMemoryPayload merge#546
Open
zhangxffff wants to merge 6 commits intobytedance:mainfrom
Open
fix: avoid buffer resize cost in shuffle reader during InMemoryPayload merge#546zhangxffff wants to merge 6 commits intobytedance:mainfrom
zhangxffff wants to merge 6 commits intobytedance:mainfrom
Conversation
This reverts commit ae44dfb.
71926d4 to
eca5241
Compare
guhaiyan0221
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #545
Type of Change
Description
BoltColumnarBatchDeserializer::next()previously merged each inboundBlockPayloadinto a runningmerged_InMemoryPayloadimmediately on arrival. With N small payloads consolidating into one output batch, this triggered N−1 calls toInMemoryPayload::merge(), and each call reallocated the destination buffer to exactly the new size — Arrow'sPoolBuffer::Reservedoes not grow capacity geometrically. The result was O(N) Arrow reallocations and O(N²) bytes copied per output batch.This PR accumulate inbound payloads size, prealloc enough size and merge when the batch is ready.
Benchmark case: 4 columns with 1024 length StringView, each payload has 4 StringView. Read cost reduce from 14.68s to 131.26ms.
Performance Impact
No Impact: This change does not affect the critical path (e.g., build system, doc, error handling).
Positive Impact: I have run benchmarks.
Click to view Benchmark Results
Negative Impact: Explained below (e.g., trade-off for correctness).
Release Note
Please describe the changes in this PR
Release Note:
Checklist (For Author)
Breaking Changes
No
Yes (Description: ...)
Click to view Breaking Changes