refactor(frontend): convert workspace settings from modal to routed pages#2720
Open
yangzheli wants to merge 3 commits intobytedance:mainfrom
Open
refactor(frontend): convert workspace settings from modal to routed pages#2720yangzheli wants to merge 3 commits intobytedance:mainfrom
yangzheli wants to merge 3 commits intobytedance:mainfrom
Conversation
…ages Replace the SettingsDialog modal with a route-based settings layout under /workspace/settings, backed by a new SettingsShell with a sticky sidebar nav. Add dedicated pages for general, account, memory, tools, skills, and about, and update command palette and workspace nav menu to navigate to these routes instead of toggling a dialog. Add the new "general" section to i18n locales and shorten a few memory action labels.
…ce-settings # Conflicts: # frontend/src/components/workspace/settings/account-settings-page.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2723
Summary
Replace the SettingsDialog modal with a route-based settings layout under /workspace/settings, backed by a new SettingsShell with a sticky sidebar nav. Add dedicated pages for general, account, memory, tools, skills, and about, and update command palette and workspace nav menu to navigate to these routes instead of toggling a dialog. Add the new "general" section to i18n locales and shorten a few memory action labels.
Proposal
A three-phase refactor:
Phase A — Memory toolbar fix. Drop
xl:flex-row, switch to a two-row responsive layout (search row, then filters + actions row withflex-wrap).Phase B — IA reorganization. Merge
Appearance+Notificationinto a newGeneralsection, moveAccountto a less prominent position, and default the entry point togeneral.Phase C — Modal → route-based pages. Replace
<SettingsDialog>with Next.js App Router routes under/workspace/settings/{section}, backed by a newSettingsShelllayout with a sticky sidebar nav. Eliminates nested scrolling and unlocks deep links, browser back / forward, and refresh persistence.Final section order: General → Account → Memory → Tools → Skills → About
Screenshots