feat(tree): add multiprocessing tree data loader #1041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix(tree): fix multiprocessing start method * chore(tree): multiprocessing reusing parameter `num_parallel` * style(tree): rename num_data_loaders to num_parallel Co-authored-by: qinminhao <[email protected]>
chong1144
reviewed
Aug 25, 2022
Lemon-412
commented
Aug 25, 2022
|
LGTM |
|
LGTM |
chong1144
approved these changes
Aug 29, 2022
Lemon-412
added a commit
to Lemon-412/fedlearner
that referenced
this pull request
Aug 30, 2022
* feat(tree): add multiprocessing dataloader * fix(tree): fix lint * fix(tree): fix multiprocessing start method (bytedance#1040) * fix(tree): fix multiprocessing start method * chore(tree): multiprocessing reusing parameter `num_parallel` * style(tree): rename num_data_loaders to num_parallel Co-authored-by: qinminhao <[email protected]> * test(tree): multiprocessing tree model test.sh * style(tree): code clean * style(tree): fix code lint(logging-not-lazy) * test(tree): move unittest to rest_trainer.py * docs(tree): more comments * fix(tree): fix code lint * style(tree): make parameter num_paralle optimal Co-authored-by: qinminhao <[email protected]>
chong1144
pushed a commit
that referenced
this pull request
Aug 30, 2022
* feat(tree): add multiprocessing dataloader * fix(tree): fix lint * fix(tree): fix multiprocessing start method (#1040) * fix(tree): fix multiprocessing start method * chore(tree): multiprocessing reusing parameter `num_parallel` * style(tree): rename num_data_loaders to num_parallel Co-authored-by: qinminhao <[email protected]> * test(tree): multiprocessing tree model test.sh * style(tree): code clean * style(tree): fix code lint(logging-not-lazy) * test(tree): move unittest to rest_trainer.py * docs(tree): more comments * fix(tree): fix code lint * style(tree): make parameter num_paralle optimal Co-authored-by: qinminhao <[email protected]> Co-authored-by: qinminhao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.