fix: clean up handles in worker_threads environments to prevent aborting #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oyyd
force-pushed
the
feat/oyyd
branch
2 times, most recently
from
7b00788 to
88a1765
Compare
oyyd
changed the title
When using in `worker_threads` Workers, Node.js will abort with messages like: ``` uv loop at [0x00000000] has open handles... ``` when workers are exiting or are terminated with active `DgramSocket` or `SeqpacketSocket`. To fix this issue, we need clean up all active uv_handles in hooks registered by `napi_add_env_cleanup_hook`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using in
worker_threadsWorkers, Node.js will abort with messages like:when workers are exiting or are terminated with active
DgramSocketorSeqpacketSocket.To fix this issue, we need clean up all active uv_handles in hooks registered by
napi_add_env_cleanup_hook.