-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use int64 for MaxInt48 to compile in x86 arch #521
Conversation
This is a fix for any non 64-bit host system |
internal/rt/int48.go
Outdated
@@ -17,20 +17,20 @@ | |||
package rt | |||
|
|||
const ( | |||
MinInt48 = -(1 << 47) | |||
MaxInt48 = +(1 << 47) - 1 | |||
MinInt48 int64 = -(1 << 47) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, maybe use 4 spaces instead of a tab~
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
thanks for your pr, The branch name is invalid in the CI, maybe we need to fix it to merge into master~ |
It was nothing. I'm just glad it's working for ya. |
Honestly even if it was able to be compiled for 386/x86, the JIT compiler only supports amd64 ABI. |
I wants to build ONE program and expect it to run on both of the x86 & x64 version of the windows , so I MUST choose the x86 program. |
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/bytedance/sonic](https://togithub.com/bytedance/sonic) | indirect | patch | `v1.10.1` -> `v1.10.2` | --- ### Release Notes <details> <summary>bytedance/sonic (github.com/bytedance/sonic)</summary> ### [`v1.10.2`](https://togithub.com/bytedance/sonic/releases/tag/v1.10.2) [Compare Source](https://togithub.com/bytedance/sonic/compare/v1.10.1...v1.10.2) #### Bugfix - \[[#​521](https://togithub.com/bytedance/sonic/issues/521)] use int64 for MaxInt48 to compile in x86 arch - \[[#​530](https://togithub.com/bytedance/sonic/issues/530)] unnecessary ptr check `json.Unmarshaler` - \[[#​531](https://togithub.com/bytedance/sonic/issues/531)] missing write-barrier when truncate empty slice - \[[#​533](https://togithub.com/bytedance/sonic/issues/533)] not use rbp in JIT #### New Contributors - [@​ancientmodern](https://togithub.com/ancientmodern) made their first contribution in [https://github.com/bytedance/sonic/pull/528](https://togithub.com/bytedance/sonic/pull/528) - [@​CrazyHarb](https://togithub.com/CrazyHarb) made their first contribution in [https://github.com/bytedance/sonic/pull/521](https://togithub.com/bytedance/sonic/pull/521) **Full Changelog**: bytedance/sonic@v1.10.1...v1.10.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 4am on the first day of the month" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDkuNCIsInVwZGF0ZWRJblZlciI6IjM2LjEwOS40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/bytedance/sonic](https://togithub.com/bytedance/sonic) | indirect | patch | `v1.10.1` -> `v1.10.2` | --- ### ⚠ Dependency Lookup Warnings ⚠ Warnings were logged while processing this repo. Please check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>bytedance/sonic (github.com/bytedance/sonic)</summary> ### [`v1.10.2`](https://togithub.com/bytedance/sonic/releases/tag/v1.10.2) [Compare Source](https://togithub.com/bytedance/sonic/compare/v1.10.1...v1.10.2) ##### Bugfix - \[[#​521](https://togithub.com/bytedance/sonic/issues/521)] use int64 for MaxInt48 to compile in x86 arch - \[[#​530](https://togithub.com/bytedance/sonic/issues/530)] unnecessary ptr check `json.Unmarshaler` - \[[#​531](https://togithub.com/bytedance/sonic/issues/531)] missing write-barrier when truncate empty slice - \[[#​533](https://togithub.com/bytedance/sonic/issues/533)] not use rbp in JIT ##### New Contributors - [@​ancientmodern](https://togithub.com/ancientmodern) made their first contribution in [https://github.com/bytedance/sonic/pull/528](https://togithub.com/bytedance/sonic/pull/528) - [@​CrazyHarb](https://togithub.com/CrazyHarb) made their first contribution in [https://github.com/bytedance/sonic/pull/521](https://togithub.com/bytedance/sonic/pull/521) **Full Changelog**: bytedance/sonic@v1.10.1...v1.10.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 4am on the first day of the month" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDkuNCIsInVwZGF0ZWRJblZlciI6IjM2LjEwOS40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->
fix error " MinInt48 (untyped int constant -140737488355328) overflows int" when compile by gox86 on windows.