Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unnecessary ptr check json.Unmarshaler #530

Merged
merged 1 commit into from
Sep 22, 2023
Merged

Conversation

AsterDY
Copy link
Collaborator

@AsterDY AsterDY commented Sep 21, 2023

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Sep 21, 2023

Codecov Report

Merging #530 (1a4e774) into main (73a97ab) will increase coverage by 0.07%.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##             main     #530      +/-   ##
==========================================
+ Coverage   78.20%   78.27%   +0.07%     
==========================================
  Files          65       69       +4     
  Lines       10602    10688      +86     
==========================================
+ Hits         8291     8366      +75     
- Misses       1959     1961       +2     
- Partials      352      361       +9     
Files Changed Coverage Δ
internal/decoder/compiler.go 69.93% <ø> (+0.73%) ⬆️

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@liuq19 liuq19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liuq19 liuq19 merged commit dd7da44 into main Sep 22, 2023
30 checks passed
@liuq19 liuq19 deleted the fix/unnecessary_ptr_check branch September 22, 2023 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants