Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove some linknames #667

Merged
merged 7 commits into from
Jul 8, 2024
Merged

fix: remove some linknames #667

merged 7 commits into from
Jul 8, 2024

Conversation

liuq19
Copy link
Collaborator

@liuq19 liuq19 commented Jul 8, 2024

Remove some unnecessary link names to support Go1.23

Related issue #637 #660

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 39.31%. Comparing base (99f5b35) to head (5a99745).
Report is 19 commits behind head on main.

Files Patch % Lines
internal/decoder/optdec/node.go 0.00% 3 Missing ⚠️
internal/rt/rt_stubs_go120.go 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

❗ There is a different number of reports uploaded between BASE (99f5b35) and HEAD (5a99745). Click for more details.

HEAD has 6 uploads less than BASE
Flag BASE (99f5b35) HEAD (5a99745)
7 1
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #667       +/-   ##
===========================================
- Coverage   77.56%   39.31%   -38.25%     
===========================================
  Files          83       84        +1     
  Lines       11542     7051     -4491     
===========================================
- Hits         8952     2772     -6180     
- Misses       2192     4039     +1847     
+ Partials      398      240      -158     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

AsterDY
AsterDY previously approved these changes Jul 8, 2024
@AsterDY AsterDY enabled auto-merge (squash) July 8, 2024 09:21
@AsterDY AsterDY merged commit 121df0a into main Jul 8, 2024
43 checks passed
@AsterDY AsterDY deleted the fix/linkname branch July 8, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants