Some modules support LoongArch64#1401
Some modules support LoongArch64#1401Panxuefeng-loongson wants to merge 1 commit intobytedeco:masterfrom
Conversation
|
@saudet RFR, thanks |
| <archive> | ||
| <manifestEntries> | ||
| <Class-Path>${javacpp.moduleId}.jar ${javacpp.moduleId}-linux-armhf.jar ${javacpp.moduleId}-linux-arm64.jar ${javacpp.moduleId}-linux-ppc64le.jar ${javacpp.moduleId}-linux-x86.jar ${javacpp.moduleId}-linux-x86_64.jar ${javacpp.moduleId}-macosx-x86_64.jar ${javacpp.moduleId}-windows-x86.jar ${javacpp.moduleId}-windows-x86_64.jar</Class-Path> | ||
| <Class-Path>${javacpp.moduleId}.jar ${javacpp.moduleId}-linux-armhf.jar ${javacpp.moduleId}-linux-arm64.jar ${javacpp.moduleId}-linux-ppc64le.jar ${javacpp.moduleId}-linux-x86.jar ${javacpp.moduleId}-linux-x86_64.jar ${javacpp.moduleId}-linux-loongarch64.jar ${javacpp.moduleId}-macosx-x86_64.jar ${javacpp.moduleId}-windows-x86.jar ${javacpp.moduleId}-windows-x86_64.jar</Class-Path> |
There was a problem hiding this comment.
Please put linux-loongarch64 after linux-arm64 for consistency, everywhere, here and in all the other files.
| # | ||
|
|
||
| -cmake_minimum_required(VERSION 3.16) | ||
| +cmake_minimum_required(VERSION 3.13.4) |
There was a problem hiding this comment.
Let's use a sed command for small changes like this:
https://github.com/bytedeco/javacpp-presets/blob/master/onnxruntime/cppbuild.sh#L69
| patch -Np1 -d $VO_AMRWBENC < ../../vo-amrwbenc-add-loongarch-cpuinfo.patch | ||
| patch -Np1 -d $X264 < ../../x264-stable-add-loongarch-cpuinfo.patch | ||
| patch -Np1 -d SVT-AV1-v$SVTAV1_VERSION < ../../change-cmake-version.patch | ||
| fi |
There was a problem hiding this comment.
Can we put all this under the case for linux-loongarch64) below?
| if [ "$PATCH_ARCH" == "loongarch64" ]; then | ||
| patch -Np1 -d libdc1394-$LIBDC1394_VERSION < ../../libdc1394-add-loongarch-cpuinfo.patch | ||
| fi | ||
|
|
There was a problem hiding this comment.
Here as well, and in all the other cppbuild.sh files below please.
| <artifactId>${javacpp.moduleId}</artifactId> | ||
| <version>${project.version}</version> | ||
| <classifier>${javacpp.platform.linux-loongarch64}</classifier> | ||
| </dependency> |
There was a problem hiding this comment.
We'll need to keep these entries in all platform/pom.xml commented out until we're able to get builds running as part of CI. You can leave them there, but just in comments for now as per other ones in the files.
|
Thanks for wasting your valuable time. I'll make adjustments to the code based on your suggestions |
2 participants
No description provided.