Fix deployment_start and _end to be different and not clipped#216
Merged
jklymak merged 2 commits intoc-proof:mainfrom Feb 27, 2025
Merged
Fix deployment_start and _end to be different and not clipped#216jklymak merged 2 commits intoc-proof:mainfrom
jklymak merged 2 commits intoc-proof:mainfrom
Conversation
Member
|
Ooops, thats embarrassing. On the other hand we will have to regenerate the test data to fix the errors in the reference data sets. Did you want to do that, or should I push to this PR? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #216 +/- ##
=======================================
Coverage 54.90% 54.90%
=======================================
Files 9 9
Lines 1692 1692
=======================================
Hits 929 929
Misses 763 763 ☔ View full report in Codecov by Sentry. |
Contributor
Author
|
Should be all good now! Wasn't sure if regenerating was something you wanted to do or if I should do. |
Member
|
Thanks a lot! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both start and end times in the timeseries NetCDF metadata were the same and missing the last digit.