Skip to content

Fix deployment_start and _end to be different and not clipped#216

Merged
jklymak merged 2 commits intoc-proof:mainfrom
cassandra-elmer:main
Feb 27, 2025
Merged

Fix deployment_start and _end to be different and not clipped#216
jklymak merged 2 commits intoc-proof:mainfrom
cassandra-elmer:main

Conversation

@cassandra-elmer
Copy link
Copy Markdown
Contributor

Both start and end times in the timeseries NetCDF metadata were the same and missing the last digit.

@jklymak
Copy link
Copy Markdown
Member

jklymak commented Feb 27, 2025

Ooops, thats embarrassing. On the other hand we will have to regenerate the test data to fix the errors in the reference data sets. Did you want to do that, or should I push to this PR?

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.90%. Comparing base (85011e5) to head (f5211fb).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #216   +/-   ##
=======================================
  Coverage   54.90%   54.90%           
=======================================
  Files           9        9           
  Lines        1692     1692           
=======================================
  Hits          929      929           
  Misses        763      763           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cassandra-elmer
Copy link
Copy Markdown
Contributor Author

Should be all good now! Wasn't sure if regenerating was something you wanted to do or if I should do.

@jklymak jklymak merged commit 7c6c18e into c-proof:main Feb 27, 2025
@jklymak
Copy link
Copy Markdown
Member

jklymak commented Feb 27, 2025

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants