Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADD: Organization and Collection to lookup. #22

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

atta
Copy link

@atta atta commented Dec 13, 2021

This will enable lager bitwarden deployments to make use of collections.
In order to have the same key stored with different values,
for multiple environments

This will enable lager bitwarden deployments to make use of collections.
In order to have the same key stored with different values,
for multiple environments
@atta
Copy link
Author

atta commented Jan 17, 2022

@c0sco hey can we talk about this request and your opinion on it!?

@evrardjp
Copy link

Any interest in this?

@kemcon
Copy link

kemcon commented Mar 22, 2022

there is a bug in def get_custom_field(self, key, field, organizationId=None, collectionId=None):
the original def get_entry is always a string, but your def get_entry is json, so you dont need to json.loads(self.get_entry...

just do:

    def get_custom_field(self, key, field, organizationId=None, collectionId=None):
        data = self.get_entry(key, 'item', organizationId, collectionId)
        return next(x for x in data['fields'] if x['name'] == field)['value']

Ansgar Jazdzewski and others added 2 commits April 1, 2022 15:45
@atta
Copy link
Author

atta commented Apr 1, 2022

there is a bug in def get_custom_field(self, key, field, organizationId=None, collectionId=None): the original def get_entry is always a string, but your def get_entry is json, so you dont need to json.loads(self.get_entry...

Thanks for the hint i did some work today toi change the way how custom fields and attachments work with Organization and Collection #25

@kemcon
Copy link

kemcon commented Apr 4, 2022

there is a bug in def get_custom_field(self, key, field, organizationId=None, collectionId=None): the original def get_entry is always a string, but your def get_entry is json, so you dont need to json.loads(self.get_entry...

Thanks for the hint i did some work today toi change the way how custom fields and attachments work with Organization and Collection #25

your welcome. i started my own fork and added a lot, but with breaking changed. especially i got rid of custom value and now one can read every single value or list from the item-json. the custom values are available with "fields.valuename", but "id" ist also possible and organziation id and collection id is available too and all is working always with the names instead of the ids.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants