Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compiler: extend command options #195

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

chqrlie
Copy link
Contributor

@chqrlie chqrlie commented Mar 26, 2025

  • rename parse_opts and parse_long_opts arguments for clarity
  • add string_list.List methods: addStr() and del()
  • made Recipe.addTarget() public
  • compiler: accept multiple targets or filenames on command line

@bvdberg
Copy link
Member

bvdberg commented Mar 26, 2025

I dont mind the renaming of comp_opts and alowing multiple targets/files, but i do mind the needless shuffling of code at the start of main(). There is no need for that.

@chqrlie
Copy link
Contributor Author

chqrlie commented Mar 26, 2025

I dont mind the renaming of comp_opts and alowing multiple targets/files, but i do mind the needless shuffling of code at the start of main(). There is no need for that.

I did not do this without purpose: I had to move the parsing past the creation of the auxPool so the file string lists can be allocated froim this pool, and I kept the other object definitions together...

@chqrlie chqrlie force-pushed the cmdline branch 4 times, most recently from 7fb24c6 to 34b3705 Compare April 2, 2025 07:50
@chqrlie chqrlie force-pushed the cmdline branch 3 times, most recently from ef76a0f to 6c0f040 Compare April 6, 2025 14:22
@chqrlie chqrlie force-pushed the cmdline branch 3 times, most recently from c50850d to ec2bc3e Compare April 14, 2025 06:55
@bvdberg
Copy link
Member

bvdberg commented Apr 14, 2025

I looked at the patch again, and I really dont like the multiple files support. It's just a step in exactly the wrong direction in my opinion. Then next step is naming the output file and enabling/disabling all the warnings through cmdline options. This is exactly what i wanted to get away from.

* rename `parse_opts` and `parse_long_opts` arguments for clarity
* add `string_list.List` methods: `addStr()` and `del()`
* made `Recipe.addTarget()` public
* compiler: accept multiple targets or filenames on command line
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants