test::eq/ne/gt syntax #1928
Merged
test::eq/ne/gt syntax #1928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lerno
reviewed
Feb 5, 2025
lib/std/core/test.c3
Outdated
| @@ -127,7 +127,7 @@ macro is_equal(left, right) | |||
| @require delta >= 0, delta <= 1 "delta must be a small number" | |||
| @require runtime::test_context != null "Only allowed in @test functions" | |||
| *> | |||
| fn void is_almost_equal(double left, double right, uint places = 7, double delta = 0, bool equal_nan = true) | |||
| macro void @almost(double left, double right, uint places = 7, double delta = 0, bool equal_nan = true) | |||
|
Ok, let's go with this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Terse tests syntax proposal #1918
The test module is refactored in the following logic:
eq/ne/gt/leare for regular use (90% of the test code), they are macros but without@.@prefix, and also reduced to 1 word (it's better to remember). Also,@will be a reminder that we might have special behavior (less mental overhead for reader).test::setupnowtest::@setuptest::is_almost_equalnowtest::@almosttest::module instead of introducing newassert_eq/ne/gtkeyword, because in the future I think it's possible to add more testing features (mocks maybe?). Andtest::is visually more readable due to::separation and different highlighting.