Hotfix #879
Open
Hotfix #879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to put it over all the others widgets. Thanks to @0MazaHacka0 for reporting it.
…o parse them as well.
put out of the loop the check for adding dots to the domain. fixes #21.
reorder TLD domains, to put simple domains (.us) at the end of the compounded domains of the same type (.com.us)
added a simple cache for already resolved TLDs.
also use a TreeSet to store them.
changed names a while.
use IOUtils from apache commons to move pcap file from cache to storage. I've also exported those small piece of code into a separate function.
Even if we tell to Java to do this it ignore our preferences. We have to do this my hand.
|
Most of this is outdated. Is this still a viable PR or should it be closed? |
umausp
reviewed
Jan 14, 2020
| t.setSelected(false); | ||
| synchronized (this) { | ||
| for (Target t : list) | ||
| t.setSelected(false); |
There was a problem hiding this comment.
Always use curly braces
for (Target t : list){
t.setSelected(false);
}
| synchronized (this) { | ||
| for (Target t : list) | ||
| t.setSelected(false); | ||
| } | ||
| notifyDataSetChanged(); |
There was a problem hiding this comment.
It is not mandatory to use notifyDataSetChanged always. if you want to update only one item in the list then you can use notifyItemChanged(position)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.