Skip to content

Commit

Permalink
Use NestedScrollView instead of ScrollView with nestedScrollingEnabled.
Browse files Browse the repository at this point in the history
Not sure if this changes anything...
  • Loading branch information
caarmen committed Jan 5, 2025
1 parent bea1acb commit 9e82443
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions app/src/main/res/layout/fragment_reader.xml
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
</data>

<!--
Set nestedScrollingEnabled="true".
Use NestedScrollView.
Without this, we have this problem:
- have a long poem already entered.
- launch the app.
Expand All @@ -44,13 +44,12 @@
- try to scroll down.
You can't scroll down to the end of the poem
-->
<ScrollView
<androidx.core.widget.NestedScrollView
android:layout_width="match_parent"
android:layout_height="match_parent"
android:clipChildren="false"
android:clipToPadding="false"
android:fillViewport="false"
android:nestedScrollingEnabled="true"
android:paddingBottom="@dimen/activity_vertical_margin"
android:paddingLeft="@dimen/activity_horizontal_margin"
android:paddingRight="@dimen/activity_horizontal_margin"
Expand Down Expand Up @@ -104,5 +103,5 @@
app:layout_constraintBottom_toBottomOf="parent"
tools:text="45 words, 300 characters"/>
</androidx.constraintlayout.widget.ConstraintLayout>
</ScrollView>
</androidx.core.widget.NestedScrollView>
</layout>

0 comments on commit 9e82443

Please sign in to comment.