Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix process-text intent filter. #191

Merged
merged 1 commit into from
May 12, 2024
Merged

Fix process-text intent filter. #191

merged 1 commit into from
May 12, 2024

Conversation

caarmen
Copy link
Owner

@caarmen caarmen commented May 12, 2024

Issue #190:

Poet assistant stops appearing in the text selection menu in some Google apps (chrome, keep, ...), starting in Android 14.

This weird change, to add the <intent-filter> for the VIEW action and the https data schema, seems to make this work again.

Also: add the android:label to the <activity> elements to make the proper labels appear in some apps which were just showing "Poet Assistant" (ex: Firefox).

Poet assistant stops appearing in the text selection menu in some Google apps (chrome, keep, ...), starting in Android 14.

This weird change, to add the `<intent-filter>` for the `VIEW` action and the `https` data schema, seems to make this work again.

Also: add the `android:label` to the `<activity>` elements to make the proper labels appear in some apps which were just showing "Poet Assistant" (ex: Firefox).
@caarmen caarmen force-pushed the fix-process-text branch from 3a0b8b2 to 93e5283 Compare May 12, 2024 15:31
@caarmen caarmen marked this pull request as ready for review May 12, 2024 16:03
@caarmen caarmen merged commit a360e40 into master May 12, 2024
2 checks passed
@caarmen caarmen deleted the fix-process-text branch May 12, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant