Skip to content

Improve ci tests#204

Merged
caarmen merged 3 commits intomasterfrom
improve-ci-tests
Oct 19, 2024
Merged

Improve ci tests#204
caarmen merged 3 commits intomasterfrom
improve-ci-tests

Conversation

@caarmen
Copy link
Copy Markdown
Owner

@caarmen caarmen commented Oct 19, 2024

Archive apks in the github actions workflow.

Improve the starting/stopping of gmsaas instances.

  • When starting an instance, specify a max run duration of 30 minutes.
  • Don't stop all instances at the beginning and end of tests. Instead, just stop the one instance we started, at the end of the test. Since we specify a max duration, we don't have to worry (as much) about having instances running forever if a test crashes.

This will allow us to run multiple PR builds in parallel.

* When starting an instance, specify a max run duration of 30 minutes.
* Don't stop all instances at the beginning and end of tests. Instead, just stop the one instance we started, at the end of the test. Since we specify a max duration, we don't have to worry (as much) about having instances running forever if a test crashes.

This will allow us to run multiple PR builds in parallel.
@caarmen caarmen marked this pull request as ready for review October 19, 2024 21:06
@caarmen caarmen force-pushed the improve-ci-tests branch 3 times, most recently from 03b3ed5 to 34b8fec Compare October 19, 2024 21:33
@github-actions
Copy link
Copy Markdown

Overall Project 80.56% 🍏

There is no coverage information present for the Files changed

1 similar comment
@github-actions
Copy link
Copy Markdown

Overall Project 80.56% 🍏

There is no coverage information present for the Files changed

@caarmen caarmen merged commit 2631109 into master Oct 19, 2024
@caarmen caarmen deleted the improve-ci-tests branch October 19, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant